This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] test-in-container: Do not set GCONV_PATH, LOCPATH
- From: DJ Delorie <dj at redhat dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 21 May 2019 09:24:20 -0400
- Subject: Re: [PATCH] test-in-container: Do not set GCONV_PATH, LOCPATH
Florian Weimer <fweimer@redhat.com> writes:
> Sorry, I don't understand. Why would the user want to run distcc *in
> the container*?
That was just an example of an environment variable that affects the
build. I don't know what environment variables affect the test cases.
Timeout-related? Without a review of *every* test that might be run in
a container, we won't know what environment variables are valid for the
user to specify.
> What reason do we have to believe that the host environment variable
> settings (regarding terminal, locales and the like) are even valid in
> the container?
We don't know they're valid, but we don't know they're invalid either.
We don't filter the environment for non-container variables. Not
over-filtering the container is at least consistent.