This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v4] Prepare vfprintf to use __printf_fp/__printf_fphex with float128 arg
On 20/05/2019 16:16, Joseph Myers wrote:
> On Mon, 20 May 2019, Adhemerval Zanella wrote:
>
>>> Well, I intentionally write small patches that are valid for master, so
>>> they can be applied sooner than later. I have written many patches this
>>> way to avoid the burden of carrying patches on personal branches.
>>>
>>> I also provided a link to such branch where the changes in this patch
>>> get tested for many of the functions added by subsequent patches.
>>>
>>> I was hoping that these things combined would provide a good
>>> justification for acceptance. With that in mind, do you have an
>>> objection to this patch?
>>
>> My main objection is currently glibc still does not support -mabi=ieeelongdouble
>> (correct me if I wrong), so it might take some time to actually test this
>> code path on powerpc.
>
> I think this is a case where the preparatory patch is sufficiently
> self-contained that it is reasonable to have is on master separately from
> others that depend on it. (This is not a review or approval of the
> details of the specific patch. And for some patches, even when they are
> reasonable to include on their own, the review of the design of the patch
> may depend on looking at the later patches in the series to see how much
> the design is forced by requirements that aren't obvious from the patch in
> isolation.)
>
Alright then, I withdrew my objection.