This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Update kernel-features.h files for Linux 5.1


16.05.2019 в 09:59:40 +0200 Arnd Bergmann написал:
> On Fri, May 10, 2019 at 3:19 PM Stepan Golosunov <stepan@golosunov.pp.ru> wrote:
> > > (I also think that ipc with IPCOP_semtimedop was accidentally made to
> > > behave like semtimedop_time64 in 32-bit builds of linux 5.1.  But that
> > > would be a kernel bug.)
> 
> Can you elaborate? The code I see in mainline is
> 
>         case SEMTIMEDOP:
>                 if (IS_ENABLED(CONFIG_64BIT) || !IS_ENABLED(CONFIG_64BIT_TIME))
>                         return ksys_semtimedop(first, ptr, second,
>                                 (const struct __kernel_timespec __user *)fifth);
>                 else if (IS_ENABLED(CONFIG_COMPAT_32BIT_TIME))
>                         return compat_ksys_semtimedop(first, ptr, second,
>                                 (const struct old_timespec32 __user *)fifth);
>                 else
>                         return -ENOSYS;
> 
> Since both CONFIG_64BIT_TIME and CONFIG_COMPAT_32BIT_TIME
> are always set on 32-bit architectures, SEMTIMEDOP passes
> an old_timespec32 argument here. Am I missing something?

If CONFIG_64BIT_TIME is set then there is no problem.  But I do not
see where it is set.  (The patch to set it to y was merged only now
and is not in 5.1.)  And if it's not set, then ipc and socketcall are
broken.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]