This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] support: Report NULL blobs explicitly in TEST_COMPARE


* Florian Weimer:

> * Florian Weimer:
>
>> Provide an explicit diagnostic if the length is positive, and
>> do not just crash with a null pointer dereference.  Null pointers
>> are only valid if the length is zero, so this can only happen with
>> a faulty test.
>>
>> 2019-05-03  Florian Weimer  <fweimer@redhat.com>
>>
>> 	* support/support_test_compare_blob.c (report_blob): Report
>> 	incorrect NULL blobs.

> Hmph, this patch is better because it does not change test failure
> output with for NULL with zero length:

I've pushed the second patch.

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]