This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] manual: Adjust twalk_r documentation.


On 5/14/19 3:49 PM, Florian Weimer wrote:
> * Carlos O'Donell:
> 
>> diff --git a/manual/search.texi b/manual/search.texi
>> index 979732f027..60c851229c 100644
>> --- a/manual/search.texi
>> +++ b/manual/search.texi
>> @@ -630,8 +630,8 @@ see the @code{twalk_r} function below.
>>  For each node in the tree with a node pointed to by @var{root}, the
>>  @code{twalk_r} function calls the function provided by the parameter
>>  @var{action}.  For leaf nodes the function is called exactly once with
>> -@var{value} set to @code{leaf}.  For internal nodes the function is
>> -called three times, setting the @var{value} parameter or @var{action} to
>> +@var{which} set to @code{leaf}.  For internal nodes the function is
>> +called three times, setting the @var{which} parameter of @var{action} to
>>  the appropriate value.  The @var{closure} parameter is passed down to
>>  each call of the @var{action} function, unmodified.
> 
> Looks good to me.  Thanks for fixing this.

I pinged you on IRC to get your Reviewed-by:, thanks for that.

Pushed.

-- 
Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]