This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v1 7/12] PPC64: Add libmvec SIMD double-precision logarithm function.
- From: Tulio Magno Quites Machado Filho <tuliom at ascii dot art dot br>
- To: GT <tnggil at protonmail dot com>, libc-alpha at sourceware dot org
- Cc:
- Date: Thu, 09 May 2019 17:08:16 -0300
- Subject: Re: [PATCH v1 7/12] PPC64: Add libmvec SIMD double-precision logarithm function.
- References: <yP1XhFk_hJCvLPzHBAsGcNSlafZymWERFuOitBV_IVNuq3KqUCastULqwaB9Juwy8MdS1Tf249BLuPII0-slIPHriTgNfnQRWxesAuo8DZo=@protonmail.com>
GT <tnggil@protonmail.com> writes:
> [BZ #24208]
>
> Implements double-precision vector logarithm function. The algorithm is
2 spaces here -----------------------------------------^
> an adaptation of the one in sysdeps/ieee754/dbl-64, modified to exploit
> PPC64 VSX hardware. The version of ieee754/dbl-64 is commit #f41b0a43e4.
>
> The patch has been tested on both Little-Endian and Big-Endian. It
> passes all the tests for double-precision logarithm run by make check.
> Integration into the make check infrastructure closely follows corres-
> ponding changes done for x86_64 in commit #6af25acc7b.
>
> 2019-05-03 Bert Tenjy <bert.tenjy@gmail.com>
>
> * NEWS: Noted the addition of PPC64 vector log function.
> * sysdeps/powerpc/bits/math-vector.h: Added log function's entry.
> * sysdeps/powerpc/powerpc64/fpu/Makefile:( CFLAGS-vec_finite_alias.c)
> added -mabi=altivec -maltivec flags.
> (CFLAGS-vec_d_log2_vsx.c, CFLAGS-vec_d_log_data.c): Added build of VSX
> SIMD log function and tests.
> * sysdeps/powerpc/powerpc64/fpu/Versions: Added log function's entry.
> * sysdeps/powerpc/powerpc64/fpu/multiarch/Makefile: (libmvec-sysdep_routines)
> (CFLAGS-vec_d_log2_vsx.c, CFLAGS-vec_d_log_data.c): Added build of VSX
> SIMD log function and tests.
> * sysdeps/powerpc/powerpc64/fpu/multiarch/math_config.h: New file.
> * sysdeps/powerpc/powerpc64/fpu/multiarch/test-double-vlen2-wrappers.c: Added
> entry for log function.
> * sysdeps/powerpc/powerpc64/fpu/multiarch/vec_d_log2_vsx.c: New file.
> * sysdeps/powerpc/powerpc64/fpu/multiarch/vec_d_log_data.c: Likewise.
> * sysdeps/unix/sysv/linux/powerpc/powerpc64/libmvec.abilist: SIMD log function added.
These lines are too long.
> diff --git a/sysdeps/powerpc/powerpc64/fpu/Makefile b/sysdeps/powerpc/powerpc64/fpu/Makefile
> index 21dc67ff73..97cd4809e4 100644
> --- a/sysdeps/powerpc/powerpc64/fpu/Makefile
> +++ b/sysdeps/powerpc/powerpc64/fpu/Makefile
> @@ -1,7 +1,7 @@
> ifeq ($(subdir),mathvec)
> libmvec-support += vec_finite_alias
>
> -CFLAGS-vec_finite_alias.c += -mvsx
> +CFLAGS-vec_finite_alias.c += -mabi=altivec -maltivec -mvsx
This is starting to get duplicated in too many places.
Need to replace this before merging this into master. Nothing to change now,
though.
> diff --git a/sysdeps/powerpc/powerpc64/fpu/multiarch/math_config.h b/sysdeps/powerpc/powerpc64/fpu/multiarch/math_config.h
> new file mode 100644
> index 0000000000..bd37906ecb
> --- /dev/null
> +++ b/sysdeps/powerpc/powerpc64/fpu/multiarch/math_config.h
> @@ -0,0 +1,189 @@
> +/* Configuration for double precision math routines.
> + Copyright (C) 2018-2019 Free Software Foundation, Inc.
s/2018-2019/2019/
Merged.
Thanks!
--
Tulio Magno