This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3 1/5] y2038: Introduce __ASSUME_TIME64_SYSCALLS define
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Lukasz Majewski <lukma at denx dot de>
- Cc: <libc-alpha at sourceware dot org>, Stepan Golosunov <stepan at golosunov dot pp dot ru>, Arnd Bergmann <arnd at arndb dot de>, Paul Eggert <eggert at cs dot ucla dot edu>
- Date: Tue, 7 May 2019 16:04:37 +0000
- Subject: Re: [PATCH v3 1/5] y2038: Introduce __ASSUME_TIME64_SYSCALLS define
- References: <20190414220841.20243-1-lukma@denx.de> <20190507131848.30980-1-lukma@denx.de> <20190507131848.30980-2-lukma@denx.de>
On Tue, 7 May 2019, Lukasz Majewski wrote:
> +/* Support for 64 bit version of time related Linux syscalls.
There are several issues with this comment.
(a) It's no longer listing or more precisely describing the syscalls in
question. "64 bit version of time related Linux syscalls" is not adequate
because of the likelihood of having more than one such set in future, with
different conditions for being present in the kernel.
(b) The several variants described in the comment are variants at the
wrong logical level for describing __ASSUME_TIME64_SYSCALLS - they are
different kinds of glibc configurations (with regard to all aspects of how
time is handled in glibc), not different kinds of syscall ABI.
__ASSUME_TIME64_SYSCALLS is a property of the Linux kernel syscall ABI.
The comment should describe its semantics in those terms (in terms of the
syscall ABI's "long"), without confusing it with other related concepts.
If these variants are described anywhere in glibc, it should be in the
internals section of the manual.
(c) The comment should not refer to the user-level interface _TIME_BITS
either, as that's also confusing features at different levels.
--
Joseph S. Myers
joseph@codesourcery.com