This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 1/2] Y2038: make __mktime_internal compatible with __time64_t


Hi Paul,

> Lukasz Majewski wrote:
> > Paul, will you find any time soon to provide next version of mktime
> > compatibility patch?  
> 
> As far as mktime compatibility goes, I think I'd rather first cause
> mktime to be compatible with __time64_t, and worry about _TIME_BITS
> later. Proposed mktime patch attached; it's similar to my previous
> proposal except it leaves the __time64_t definition in
> posix/bits/types.h rather than moving it to time/mktime-internal.h.
> 
> This patch exposes __time64_t to user code if _LIBC is defined
> (because glibc needs __time64_t internally), or if __TIMESIZE != 64
> (because of the compromise to expose __time64_t only on 32-bit time_t
> platforms). Once we add _TIME_BITS I expect that we should change the
> visibility rule to something that also involves _TIME_BITS, because
> __time64_t should not be exposed to user code if _TIME_BITS == 64.
> However, that can wait for the patches involving _TIME_BITS.

Thank you very much for this patch - I've tested it in my setup and it
works.

Tested-by: Lukasz Majewski <lukma@denx.de>


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

Attachment: pgpW04ByT3vlI.pgp
Description: OpenPGP digital signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]