This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] <semaphore.h>: Add nonnull attributes


* Yann Droneaud:

> Le lundi 29 avril 2019 à 08:42 +0200, Florian Weimer a écrit :
>> * Yann Droneaud:
>> 
>> > Except the following functions, NPTL implementation assume sem_t
>> > argument (or other arguments) are not NULL, so they would benefit
>> > from having the nonnull attribute.
>> > 
>> > - sem_close(): can cope with a NULL sem_t and return -1 with error
>> > EINVAL;
>> > - sem_destroy(): does nothing at all
>> > 
>> > 	* sysdeps/pthread/semaphore.h (sem_init): Add __nonnull
>> > attribute.
>> > 	(sem_destroy, sem_open, sem_close, sem_unlink): Likewise.
>> > 	(sem_wait, sem_timedwait, sem_trywait, sem_post): Likewise.
>> > 	(sem_getvalue): Likewise.
>> 
>> Yann, do you need help with isntalling this patch?
>> 
>
> Yes please: I have no account on any GNU server.

Okay, I will install this after testing.

> Also note I have not signed any copyright assignment. But I'm willing
> to, for me and my own company.

It seems that we have one previous contribution from you, in commit
a092b645f8 ("Fix DEBUG statements in resolv/res_send.c").  But it has
been removed by commit 09fbb56ad6 ("resolv: Remove DEBUG from
resolv/res_send.c"), so I think we can accept your new contribution
as-is, since it is below the 15 line limit in the FSF guidelines.

Nevertheless, please get the process going.  You should send this form

<http://git.savannah.gnu.org/cgit/gnulib.git/plain/doc/Copyright/request-assign.future>

to <assign@gnu.org>.

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]