This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 4/5] support: implement xpthread key create/delete
----- On Apr 23, 2019, at 8:14 AM, Florian Weimer fweimer@redhat.com wrote:
> * Mathieu Desnoyers:
>
>> diff --git a/support/xpthread_key_create.c b/support/xpthread_key_create.c
>> new file mode 100644
>> index 0000000000..a493de6c99
>> --- /dev/null
>> +++ b/support/xpthread_key_create.c
>> @@ -0,0 +1,25 @@
>> +/* pthread_key_create with error checking.
>> +
>> + Copyright (C) 2019 Free Software Foundation, Inc.
>
> I think that in general, we do not have an empty line there.
OK!
>
>> +void
>> +xpthread_key_create (pthread_key_t *key, void (*destr_function) (void *))
>> +{
>> + xpthread_check_return ("pthread_key_create", pthread_key_create (key,
>> destr_function));
>> +}
>
> Please wrap this long line before pthread_key_create.
>
> Rest looks okay to me if you add a ChangeLog entry.
Done. Those will be fixed in the new round.
Thanks for the review!
Mathieu
>
> Thanks,
> Florian
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com