This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 4/5] support: implement xpthread key create/delete
- From: Florian Weimer <fweimer at redhat dot com>
- To: Mathieu Desnoyers <mathieu dot desnoyers at efficios dot com>
- Cc: Carlos O'Donell <carlos at redhat dot com>, Joseph Myers <joseph at codesourcery dot com>, Szabolcs Nagy <szabolcs dot nagy at arm dot com>, libc-alpha at sourceware dot org
- Date: Tue, 23 Apr 2019 14:14:30 +0200
- Subject: Re: [PATCH 4/5] support: implement xpthread key create/delete
- References: <20190422175623.6134-1-mathieu.desnoyers@efficios.com> <20190422175623.6134-5-mathieu.desnoyers@efficios.com>
* Mathieu Desnoyers:
> diff --git a/support/xpthread_key_create.c b/support/xpthread_key_create.c
> new file mode 100644
> index 0000000000..a493de6c99
> --- /dev/null
> +++ b/support/xpthread_key_create.c
> @@ -0,0 +1,25 @@
> +/* pthread_key_create with error checking.
> +
> + Copyright (C) 2019 Free Software Foundation, Inc.
I think that in general, we do not have an empty line there.
> +void
> +xpthread_key_create (pthread_key_t *key, void (*destr_function) (void *))
> +{
> + xpthread_check_return ("pthread_key_create", pthread_key_create (key, destr_function));
> +}
Please wrap this long line before pthread_key_create.
Rest looks okay to me if you add a ChangeLog entry.
Thanks,
Florian