This series addresses some of LGTM warnings. Source:
https://lgtm.com/projects/g/bminor/glibc/alerts/?mode=tree&ruleFocus=7900090
There is still a lot more to be addressed, but I'm just doing a sweep
over interesting to me projects and will probably come back to the
rest
of warnings once this series is merged.
I don't have write access to the repository.
changes since v2:
* added "Reviewed-by" to the python patch
* droppped patch changing ns_msg_getflag as it could break API
* I decided to drop the patch modifying resolv_test_start()
because it
seems to only be used for testing, i.e. marginal performance
improvement
wouldn't matter much, whereas on the other side, this code is
simply
clearer with passing by-value (the code goes: α. accept the
struct, β.
modify the struct, γ. copy the whole struct to another one. In
the
"by-const-pointer" case a mutable field has to be a separate
variable,
which would increase mental burden as it co-exists with the
original
field)
* did "make check", no changes before and after the series
applied.
Konstantin Kharlamov (3):
support: don't pass to set_search_path a big struct by value
nss/grp: don't pass src by value to copy_grp
python scripts: don't use "==" to compare to None
grp/grp-merge.c | 24 ++++++++++++------------
grp/grp-merge.h | 2 +-
math/gen-tgmath-tests.py | 6 +++---
nptl/nptl-printers.py | 2 +-
nss/getXXbyYY_r.c | 6 +++---
support/resolv_test.c | 12 ++++++------
6 files changed, 26 insertions(+), 26 deletions(-)
--
2.21.0