This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Linux: Define struct termios2 in <termios.h> under _GNU_SOURCE [BZ #10339]


On Tue, Apr 9, 2019 at 12:34 PM Florian Weimer <fweimer@redhat.com> wrote:
> * Zack Weinberg:
>
> > All new installed headers should have multiple inclusion guards, even
> > if they are bits headers only intended to be included by one parent
> > header.  This removes noise from the "Multiple include guards may be
> > useful for:" diagnostic produced by gcc -H, and prevents e.g.
> >
> >     #include <termios.h>
> >     #include <bits/termios2-struct.h>
> >
> > from spewing unhelpful errors (yes, the above is incorrect, but we
> > should still try to avoid diagnostic spew).
>
> Have there been any patches that follow this practice?  It's the first
> time I hear about it.

I thought this was standard practice for a long time now, but I could be wrong.

zw


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]