This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 4/4] rseq registration tests (v2)

On 4/5/19 3:43 PM, Florian Weimer wrote:

* Carlos O'Donell:


A call to pthread_join does not re-evaluate the stack cache limits and does
not free anything from the cache.


Are you sure?  I assumed that we have this call stack:

   pthread_join
   __pthread_timedjoin_ex
   __free_tcb
   __deallocate_stack
   queue_stack
   free_stacks

And since we call __free_tcb only after the futex wait on the TID
completes, free_stacks observe the stack of the just-joined thread as
unused.


(CC list trimmed)

You are correct. Thanks for noting the call to queue_stacks in
__deallocate_stack, I missed that, I thought we added directly
to the cache.

--
Cheers,
Carlos.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]