This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 4/4] rseq registration tests (v2)
- From: Florian Weimer <fweimer at redhat dot com>
- To: Carlos O'Donell <codonell at redhat dot com>
- Cc: Mathieu Desnoyers <mathieu dot desnoyers at efficios dot com>, carlos <carlos at redhat dot com>, Joseph Myers <joseph at codesourcery dot com>, Szabolcs Nagy <szabolcs dot nagy at arm dot com>, libc-alpha <libc-alpha at sourceware dot org>, Thomas Gleixner <tglx at linutronix dot de>, Ben Maurer <bmaurer at fb dot com>, Peter Zijlstra <peterz at infradead dot org>, "Paul E. McKenney" <paulmck at linux dot vnet dot ibm dot com>, Boqun Feng <boqun dot feng at gmail dot com>, Will Deacon <will dot deacon at arm dot com>, Dave Watson <davejwatson at fb dot com>, Paul Turner <pjt at google dot com>
- Date: Fri, 05 Apr 2019 21:43:25 +0200
- Subject: Re: [PATCH 4/4] rseq registration tests (v2)
- References: <20190212194253.1951-1-mathieu.desnoyers@efficios.com> <20190212194253.1951-5-mathieu.desnoyers@efficios.com> <bba18ac5-ec26-9fc6-689c-a499f4028047@redhat.com> <1950762361.2578.1554408264573.JavaMail.zimbra@efficios.com> <fc35274f-3723-1cf3-bfe2-2bbf6c22438d@redhat.com> <874l7c4vq7.fsf@oldenburg2.str.redhat.com> <b0ff0f73-0256-4191-dd5d-6db35e247c80@redhat.com> <87ef6gzd45.fsf@oldenburg2.str.redhat.com> <e31ee3e4-86ab-a26f-530a-8d39b3cd9434@redhat.com>
* Carlos O'Donell:
> A call to pthread_join does not re-evaluate the stack cache limits and does
> not free anything from the cache.
Are you sure? I assumed that we have this call stack:
pthread_join
__pthread_timedjoin_ex
__free_tcb
__deallocate_stack
queue_stack
free_stacks
And since we call __free_tcb only after the futex wait on the TID
completes, free_stacks observe the stack of the just-joined thread as
unused.
(We should probably trim the Cc: list at this point, sorry.)
Thanks,
Florian