This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 1/2] Y2038: make __mktime_internal compatible with __time64_t
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Lukasz Majewski <lukma at denx dot de>
- Cc: Paul Eggert <eggert at cs dot ucla dot edu>, <libc-alpha at sourceware dot org>
- Date: Mon, 1 Apr 2019 20:17:28 +0000
- Subject: Re: [PATCH v2 1/2] Y2038: make __mktime_internal compatible with __time64_t
- References: <20190227112042.1794-1-lukma@denx.de> <a238c752-2cfa-17f3-9676-943d75294aa3@cs.ucla.edu> <20190312075856.33ac3c5b@jawa> <bf6ca98d-da93-0677-99d3-86c80e5470a2@cs.ucla.edu> <20190319143956.52f83a48@jawa> <910c75f2-86ea-34cd-7279-71fcbf5edabc@cs.ucla.edu> <20190323125906.699ce15e@jawa> <e2295394-1af5-1e5a-d3da-9bcf28bc847c@cs.ucla.edu> <20190328095905.5900ddd9@jawa> <e8d7c72f-eb04-8890-dd39-d863c7e8d47b@cs.ucla.edu> <20190329152452.19d7b78c@jawa>
On Fri, 29 Mar 2019, Lukasz Majewski wrote:
> I've proposed to install struct __timespec64/__timeval64
> in ./include/bits/types directory of glibc (and as fair as I understand
> those would be private).
Almost all include/bits headers are single-line wrappers round the
installed header. Given that <bits/*.h> is a namespace specifically for
*installed* header fragments included from other installed headers, you
need a very good reason to put actual type definitions in include/bits/.
> But also, those can be placed in ./include/time.h
Yes, that's a more appropriate place for internal type definitions.
--
Joseph S. Myers
joseph@codesourcery.com