Re: [PATCH 4/4] ja_JP locale: Add entry for the new Japanese era [BZ #22964]

[Rafal Luzynski <digitalfreak at lingonborough dot com>]

Hello TAMUKI-san,

Thank you for continuing my work and adding this new patch.  Please
see below:

1.04.2019 06:00 TAMUKI Shoichi <tamuki@linet.gr.jp> wrote:
> 
> 
> The Japanese era name will be changed on May 1, 2019.  The Japanese
> government made a preliminary announcement on April 1, 2019.
> [...]

I believe this patch is very urgent and must be reviewed and pushed
as soon as possible.  If that's helpful, please consider splitting
it as a separate patch.  If that's helpful please consider rebasing
it against the current master (because I believe that now it depends
on the other patches of the series) or even separating it from the
test cases.  I believe you will want to backport it to some older
branches and the patch may not be easily applicable if it depends
on other patches.

> [...]
> diff --git a/NEWS b/NEWS
> index 684752ed53..4ad1ae65af 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -22,6 +22,8 @@ Major new features:
>    alternative calendar for the following locales: zh_TW, cmn_TW, hak_TW,
>    nan_TW, lzh_TW.
>  
> +* The entry for the new Japanese era has been added for ja_JP locale.
> +

I think that this new feature is so important that it deserves some
longer description.  However, I don't have any proposal at the moment
and I will no longer complain if other people find this description
sufficient.

Regards,

Rafal