Re: [PATCH] Add verbose comments to 'era' in ja_JP locale.

[Rafal Luzynski <digitalfreak at lingonborough dot com>]

28.03.2019 19:09 Carlos O'Donell <codonell@redhat.com> wrote:
> 
> Rafal,
> 
> While reviewing DJ's new test I went through all the dates, years,
> and names, and figured I'd put them into a verbose comment in ja_JP
> to make this easier to maintain in the future.
> 
> What do you think of this for master?

Sadly, I don't have enough knowledge about Japanese calendar to verify
if your comments are correct or not.  Fortunately I can see Tamuki
Shoichi on the CC: list so I hope to read some feedback from him.

Few remarks below, though:

> 8< --- 8< ---- 8<
> ---
>   localedata/locales/ja_JP | 23 +++++++++++++++++++++++
>   1 file changed, 23 insertions(+)
> 
> diff --git a/localedata/locales/ja_JP b/localedata/locales/ja_JP
> index 9bfbb2bb9b..74ef9e39f3 100644
> --- a/localedata/locales/ja_JP
> +++ b/localedata/locales/ja_JP
> @@ -14946,6 +14946,29 @@ am_pm	"<U5348><U524D>";"<U5348><U5F8C>"
> [...]
> +# Offset: Start date:	End date:	Era name:	Using "gan":
> +# (Y)     (YYYY-MM-DD)
> +# 2       1990-01-01	+*		平成 (Heisei)	No

What does the symbol "+*" mean?  Am I the only one confused?  Does
it maybe mean "infinity"?  Can we use anything different, like "+inf"?

> +# 1       1989-01-08	1989-12-31	平成 (Heisei)	Yes
> +# 2       1927-01-01	1989-01-07	昭和 (Shōwa)	No
> +# 1       1926-12-25	1926-12-31	昭和 (Shōwa)	Yes
> +# 2       1913-01-01	1926-12-24	大正 (Taishō)	No
> +# 1       1912-07-30	1912-12-31	大正 (Taishō)	Yes
> +# 6       1873-01-01	1912-07-29	明治 (Meiji)	No
> +# 1       0001-01-01	1872-12-31	西暦 (C.E)	No
> +# 1       -0000-12-31	-*		紀元前 (B.C.E.)	No

I was going to complain that the column with "Yes" and "No" is badly
unaligned.  It appears bad in my email client but it became aligned
when I clicked "reply".  Just please make sure all columns are aligned.
Unfortunately, this time "-*" (again, is this anything like "-inf"?)
looks shifted too much to the right and pushes the following columns.

Hm... if it means "-inf" then shouldn't the columns be swapped, I mean
"Start date: -inf, End date: -0001-12-31"?

(Yes, I read your another email as well.)

> +#
> +# Note:
> +# - The last entry 紀元前 means pre-era/B.C./B.C.E.
> +# - The second-to-last entry 西暦 means C.E.

Aren't the terms "B.C.", "B.C.E.", and "C.E." reserved for the
Christian calendar?  I'm sorry about my ignorance.

I think I need further explanations before I tell any opinion about
this patch.  Of course, I'll appreciate if other people give more
valuable feedback.

Regards,

Rafal