Re: [PATCH] ChangeLog: Correct two dates.

[Carlos O'Donell <codonell at redhat dot com>]

On 3/27/19 9:52 AM, Rafal Luzynski wrote:
> Carlos,
>
> 27.03.2019 14:41 Carlos O'Donell <codonell@redhat.com> wrote:
> > On 3/27/19 7:53 AM, Rafal Luzynski wrote:
> > > [...]
> > > It's only in master and only after 2.29 release.  Also I'm not touching
> > > one-off errors as long as they don't break the chronological order.
> > > After all, these dates might have been correct in some time zones. :)
> >
> > No, these dates were obviously mistakes.
> >
> > Please correct them. They should match checkin dates in git.
> >
> > Reviewed-by: Carlos O'Donell <carlos@redhat.com>
>
> Thanks for your reply.  However, your answer is ambiguous, probably
> because my questions were ambiguous.  After reading twice I must ask
> if I understand you correctly.  Do you mean that those corrections
> are OK but I should also correct more dates if I discover that the
> dates do not match?

My 'Reviewed-by' indicates my belief that your patch is OK for master.

> Does your answer mean this patch is OK to push but I should prepare
> another similar patch and send it for a review?

Yes it is OK to push your current patch.

Yes it is OK to push *other* patches that correct the dates to match
the git commit dates.

In the future we'll generate the Changelog entry from the git commit
and then the dates will never be wrong.

Right Siddhesh?

--
Cheers,
Carlos.