This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] ChangeLog: Correct two dates.

Carlos,

27.03.2019 14:41 Carlos O'Donell <codonell@redhat.com> wrote:
> On 3/27/19 7:53 AM, Rafal Luzynski wrote:
> > [...]
> > It's only in master and only after 2.29 release.  Also I'm not touching
> > one-off errors as long as they don't break the chronological order.
> > After all, these dates might have been correct in some time zones. :)
> 
> No, these dates were obviously mistakes.
> 
> Please correct them. They should match checkin dates in git.
> 
> Reviewed-by: Carlos O'Donell <carlos@redhat.com>  

Thanks for your reply.  However, your answer is ambiguous, probably
because my questions were ambiguous.  After reading twice I must ask
if I understand you correctly.  Do you mean that those corrections
are OK but I should also correct more dates if I discover that the
dates do not match?

Does your answer mean this patch is OK to push but I should prepare
another similar patch and send it for a review?

Regards,

Rafal
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]