Re: [PATCH 1/5] support: don't pass to set_search_path a big struct by value

[Konstantin Kharlamov <hi-angel at yandex dot ru>]

It matters in terms of the code as read by human: α) one would no 
longer wonder why "by-value" is used instead of a "by-pointer", and β) 
the warning by static analyzer ceases to exist.

-----

Thanks for comments! I'll address the other comments (one about testing 
suite + one patch changes ABI, have to be dropped), likely, on the 
weekend, and will resend v2 of the series.

On Пн, Mar 25, 2019 at 09:38, Florian Weimer <fw@deneb.enyo.de> wrote:
> * Konstantin Kharlamov:
>
> >   /* Copy the search path from CONFIG.search to the _res object.  */
> >   static void
> >  -set_search_path (struct resolv_redirect_config config)
> >  +set_search_path (const struct resolv_redirect_config* config)
>
> This static function is called once and therefore inlined, so the
> change does not matter.