Re: [PATCH v2 1/2] Y2038: make __mktime_internal compatible with __time64_t

[Lukasz Majewski <lukma at denx dot de>]

Hi Paul,

> Hi Paul,
> 
> > On 3/20/19 12:03 AM, Lukasz Majewski wrote:  
> > > Do you plan to prepare (and send to mailing list) the next version
> > > of this patch (including the above fix)?  
> > 
> > Sure, attached.
> >   
> > > In the time/mktime.c there is:
> > > weak_alias (mktime, timelocal), which makes the timelocal calls
> > > aliases to mktime for time_t 32 and 64 bit (for Y2038 the proper
> > > __REDIRECT will be added).  
> > > Sorry, I'm a bit lost here. How will that __REDIRECT work,
> > > exactly? Should it be part of this patch, or part of a later
> > > patch? The __REDIRECT would be a part of the latter patch - the
> > > one which adds Y2038 support for 32 bit SoCs.
> > >
> > > It would simply redirect calls to mktime/timegm to internal
> > > __mktime64()/__timegm64().
> > >  
> > OK, in that case, it can redirect timelocal calls to __mktime64, and
> > there is no need for a __timelocal64.
> >   
> 
> Thanks for the updated patch. I don't know why I've just received your
> e-mail (but it is from Friday).
> 
> Today (Sat, around 12:00 CET), I've spent some time on testing your
> previous work and write some comments/fixes in the other mail.
> 
> The code can be found in:
> https://github.com/lmajewski/y2038_glibc/commits/mktime_v3_fixes

Please find the notification about this branch being updated (in the
case you have already fetched it).

> 
> The biggest problem from Y2038 support point of view is with removing
> __time64_t from posix/bits/types.h
> (more explanation in the other mail).
> 
> 
> Best regards,
> 
> Lukasz Majewski
> 
> --
> 
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
> lukma@denx.de




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

Attachment: pgp1I9X4PcYmm.pgp
Description: OpenPGP digital signature