This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] aarch64: thunderx2 memcpy branches reordering
On 22/03/2019 05:13, Anton Youdkevitch wrote:
> Adhemerval,
>
> On 3/21/2019 23:38, Adhemerval Zanella wrote:
>> If is just a non functional change, you should indicate it. However it
>> does change the code and thus for such refactor patches on arch-specific
>> implementations we usually ask for, besides running the testcase for
>> regression (which is also not indicate in your message in which platform
>> you actually has tested), that at least some performance evaluation is
>> provided (even if this shows no gain).
> make check - no regressions
> make bench - no performance regressions for memcpy
>
> Should I resubmit the same patch with the description mentioning it is a
> non functional change?
I think the provided information should be suffice. It also a good thing
the patch could reduce code size (from 2964 to 2736), so I am ok with this
change.
Szabolcs, are you ok with this change?