This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 5/6] Refactor hp-timing rtld usage
- From: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Cc: nd <nd at arm dot com>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Date: Fri, 8 Mar 2019 14:36:04 +0000
- Subject: Re: [PATCH v2 5/6] Refactor hp-timing rtld usage
Hi Adhemerval,
> Changes from previous version:
>
> - Add rtld_timer_start, rtld_timer_stop, and rtld_timer_accum to simplify
> the profiling timer calculation. It allows remove the declaration of
> some temporary variables.
>
> - Simplify print_statistics and refactor HP_TIMING_PRINT to remove 'cycle'
> print.
LGTM. It can likely be cleaned up further to remove the remaining #ifdefs but that
can be done as a followup.
Wilco