Re: [PATCH v3] localedata: Add Minguo calendar support to zh_TW [BZ #24293]

[Rafal Luzynski <digitalfreak at lingonborough dot com>]

Hello Felix,

Thank you for the next version of your patch.

2.03.2019 18:11 Felix Yan <felixonmars@archlinux.org> wrote:
> 
> Minguo calendar is the official calendar system, and very widely used in
> Taiwan, it would be nice to have the support in glibc.

The commit language should be straight and simple, "it would be nice..."
is nice but not necessary, I think.  Also, it will be part of the
repository,
no need to express a wish when it will have been already fulfilled. :-)

> Some background information: The government website (www.gov.tw) uses it,
> popular public services like Taiwan HSR also uses this calendar system.

"also uses" -> "also use" (plural).

> Link to wikipedia: https://en.wikipedia.org/wiki/Minguo_calendar

"wikipedia" -> "Wikipedia".  Otherwise correct.

> 
>         [BZ #24293]
>         * localedata/locales/zh_TW (era): Add, support Minguo calendar.

All updated files must be listed here alphabetically, if the comment is
the same it should be replaced with "Likewise." E.g.,

        [BZ #24293]
        * localedata/locales/cmn_TW (era): Add, support Minguo calendar.
        * localedata/locales/hak_TW (era): Likewise.
        * ...

> ---
>  localedata/locales/cmn_TW | 4 ++++
>  localedata/locales/hak_TW | 4 ++++
>  localedata/locales/lzh_TW | 4 ++++
>  localedata/locales/nan_TW | 4 ++++
>  localedata/locales/zh_TW  | 4 ++++
>  5 files changed, 20 insertions(+)
> 
> diff --git a/localedata/locales/cmn_TW b/localedata/locales/cmn_TW
> index cca7cc19af..9d9aca0f9e 100644
> --- a/localedata/locales/cmn_TW
> +++ b/localedata/locales/cmn_TW
> @@ -119,6 +119,10 @@ am_pm         "<U4E0A><U5348>";/
>  t_fmt_ampm    "%p %I<U9EDE>%M<U5206>%S<U79D2>"
>  % %Y年 %b %-d號 %A %H:%M:%S %Z
>  date_fmt      "%Y<U5E74> %b %-d<U865F> %A %H:%M:%S %Z"
> +
> +era "+:2:1913//01//01:+*:<U6C11><U570B>:%EC%Ey<U5E74>";/
> +    "+:1:1912//01//01:1912//12//31:<U6C11><U570B>:%EC<U5143><U5E74>";/
> +    "+:1:1911//12//31:-*:<U6C11><U524D>:%EC%Ey<U5E74>"
>  END LC_TIME

Do I see correctly that the content of "era" is the same in all locales?
Please forgive me my ignorance, is this correct despite these are different
languages?

Regards,

Rafal