This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RESEND] [PATCH] PPC64: First in the series of patches implementing
- From: Joseph Myers <joseph at codesourcery dot com>
- To: GT <tnggil at protonmail dot com>
- Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Date: Fri, 1 Mar 2019 22:09:46 +0000
- Subject: Re: [RESEND] [PATCH] PPC64: First in the series of patches implementing
- References: <CAGWvnykktWuDVLrMrOiLrGV9aOUUQNd8Bf1FiiWbQ_G-aXJyvQ@mail.gmail.com> <alpine.DEB.2.21.1902281514280.4473@digraph.polyomino.org.uk> <87lg1zn687.fsf@linux.ibm.com> <alpine.DEB.2.21.1902281810270.20103@digraph.polyomino.org.uk> <87ef7rn3uj.fsf@linux.ibm.com> <Va5DLyFouG-pOYSW0osnuTg2RRjCEsQF6mYXCKNTFZSE4h0fX0kAOkH8-0EMivO0tMrSn-T2jK7GBNBcQnI_vjkMjgeb7sjPscHVOlqf_ao=@protonmail.com>
On Fri, 1 Mar 2019, GT wrote:
> Does the following procedure accomplish 'no change to API/ABI':
>
> - Introduce a new preprocessor macro PPC64_VSX_DISABLE_LIBMVEC
> - In sysdeps/powerpc/bits/math-vector.h, change:
That name is in the user's namespace, so it should not be tested in any
installed header.
If you're not changing the API/ABI, I don't think the patches belong in
glibc master (as opposed to on some branch, and on the branch you can just
enable the features by default). This isn't a case where a long series of
preparatory patches are needed before adding a feature (which is the sort
of case where preparation for a new feature might be appropriate on master
long before the feature itself); the main preparation for the feature was
all done in the x86_64 context.
--
Joseph S. Myers
joseph@codesourcery.com