This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[COMMITTED] nptl: Fix pthread_tryjoin comment.
- From: Carlos O'Donell <carlos at redhat dot com>
- To: GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 15 Feb 2019 12:23:12 -0500
- Subject: [COMMITTED] nptl: Fix pthread_tryjoin comment.
After Adhemerval's cleanup the only remaining comment fix is this
one and I've just committed it because it's obviously correct.
Cheers,
Carlos.
8<
In pthread_tryjoin if pd->tid == 0 then we will not block on a
futex operation because we will immediately see the join is already
complete and return. The comment is fixed to reflect that.
Signed-off-by: Carlos O'Donell <carlos@redhat.com>
---
ChangeLog | 4 ++++
nptl/pthread_tryjoin.c | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/ChangeLog b/ChangeLog
index fee6c0fd2d..cb58798e0b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2019-02-11 Carlos O'Donell <carlos@redhat.com>
+
+ * nptl/pthread_tryjoin.c: Fix comment.
+
2019-02-15 Joseph Myers <joseph@codesourcery.com>
* sunrpc/tst-svc_register.c (rpcbind_address): Remove qualifier
diff --git a/nptl/pthread_tryjoin.c b/nptl/pthread_tryjoin.c
index aa4fe07af5..7dbf22868d 100644
--- a/nptl/pthread_tryjoin.c
+++ b/nptl/pthread_tryjoin.c
@@ -26,7 +26,7 @@ pthread_tryjoin_np (pthread_t threadid, void **thread_return)
if (pd->tid != 0)
return EBUSY;
- /* If pd->tid != 0 then lll_wait_tid will not block on futex
+ /* If pd->tid == 0 then lll_wait_tid will not block on futex
operation. */
return __pthread_timedjoin_ex (threadid, thread_return, NULL, false);
}
--
2.20.1