This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] testsuite: stdlib/isomac.c: add missing include
- From: Aurelien Jarno <aurelien at aurel32 dot net>
- To: libc-alpha at sourceware dot org
- Date: Sat, 2 Feb 2019 11:57:29 +0100
- Subject: Re: [PATCH] testsuite: stdlib/isomac.c: add missing include
- References: <20190108201038.20996-1-aurelien@aurel32.net>
On 2019-01-08 21:10, Aurelien Jarno wrote:
> When running the testsuite, building stdlib/isomac.c outputs the
> following warning:
>
> gcc -O -D_GNU_SOURCE -DIS_IN_build -include /home/aurel32/glibc-build/config.h isomac.c -o /home/aurel32/glibc-build/stdlib/isomac
> isomac.c: In function ‘get_null_defines’:
> isomac.c:260:3: warning: implicit declaration of function ‘close’; did you mean ‘pclose’? [-Wimplicit-function-declaration]
> close (fd);
> ^~~~~
> pclose
>
> Fix that by adding the <unistd.h> include.
>
Ping, now that master is opened again for development, is this patch
fine to be committed?
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net