This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: misc/tst-preadvwritev2 incorrect test of [BZ #23579"]
- From: Florian Weimer <fweimer at redhat dot com>
- To: Sergey Kolosov <skolosov at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 25 Jan 2019 14:40:42 +0100
- Subject: Re: misc/tst-preadvwritev2 incorrect test of [BZ #23579"]
- References: <3f627b1cc1dae4dec43f1b63f5ccec3b704a80db.camel@redhat.com>
* Sergey Kolosov:
> glibc misc/tst-preadvwritev2 and misc/tst-preadvwritev64v2 tests are
> always passing even on unpatched glibc. I've found out that added test
> case function do_test_with_invalid_fd() checks preadv2 (-1, &iov, 1, 0,
> RWF_HIPRI) result with TEST_VERIFY (errno == EBADF || errno ==
> ENOTSUP), that means both values(correct EBADF and incorrect ENOTSUP)
> are considered valid, so the test is always passing.
I think we need to probe first if there is emulation or not, and skip
the test if there is kernel support.
Do you want to work on a patch?
Thanks,
Florian