This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: 2.29 freeze update: Last fortnight
- From: TAMUKI Shoichi <tamuki at linet dot gr dot jp>
- To: Rafal Luzynski <digitalfreak at lingonborough dot com>, libc-alpha at sourceware dot org
- Cc: Siddhesh Poyarekar <siddhesh at gotplt dot org>, Carlos O'Donell <carlos at redhat dot com>, Joseph Myers <joseph at codesourcery dot com>
- Date: Fri, 18 Jan 2019 22:58:44 +0900
- Subject: Re: 2.29 freeze update: Last fortnight
- References: <1865205043.400427.1547757143966@poczta.nazwa.pl>
Hello Rafal,
From: Rafal Luzynski <digitalfreak@lingonborough.com>
Subject: Re: 2.29 freeze update: Last fortnight
Date: Thu, 17 Jan 2019 21:32:23 +0100 (CET)
> Passing a variable by the pointer suggests that it is an input/output
> argument (or maybe even only output). Do you use the value of yr_spec
> as an additional result of __strftime_internal? I can't see any
> occurrence of yr_spec being read by the caller.
I checked carefully and confirmed that using yr_spec as a simple int
is no problem. In addition, I also found that "yr_spec = 0" after
__strftime_internal function call is unnecessary. Based on this, I
will fix the next patch.
Regards,
TAMUKI Shoichi