This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v6 1/2] strftime: Set the default width of "%Ey" to 2 [BZ #23758]


Hello Zack,

Thank you for reviewing my patch's documentation and commit messages.
Almost all the things I wanted to say were expressed and I think that
is very nice.

Also, Rafal and Paul, thank you for reviewing my patch's documentation
and commit messages.

I will soon prepare a new version set of patches with these remarks
applied.

From: Zack Weinberg <zackw@panix.com>
Subject: Re: [PATCH v6 1/2] strftime: Set the default width of "%Ey" to 2 [BZ #23758]
Date: Wed, 16 Jan 2019 11:17:09 -0500

> > The Japanese era name is scheduled to be changed on May 1, 2019.
> > Prior to this, change the alternative representation for year in
> > strftime to pad the number with zero to keep it constant width, so
> > that prevent the trouble we saw in the past from becoming obvious
> > again from the year after the era name changes onward.
> > 
> > Since only one Japanese era name is used by each emperor's reign as
> > lately, it is rare that the year ends in one digit or lasts more than
> > three digits.  In addition, the default width of month, day, hour,
> > minute, and second is 2, so adjust the default width of year the same
> > as them, and then the whole display balance is improved.  Therefore,
> > it would be reasonable to set the default width padding with zero of
> > "%Ey" to 2.
> 
> This commit message will not be clear to readers who are not familiar
> with Japanese era dating.  I had to look it up myself.  It also needs
> to make clear that %Ey is changed for all locales, not just Japanese
> locales, and this is expected to be harmless for locales that use %Ey
> for something else.  (I see you mentioned this in the commit message
> for the %EY change, but it belongs here.)
> 
> Based on what I learned, I suggest this instead:
> 
> | In Japanese locales, strftime's alternative year format (%Ey)
> | produces the year of the current era (neng?).  A new era typically
> | begins when a new emperor is enthroned.  The year of the current
> | era is therefore usually a one- or two-digit number.

I'm sorry, but I did not understand the meaning of (neng?).  I will
rewrite it to (Japanese Calendar) tentatively.

Regards,
TAMUKI Shoichi


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]