This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix handling of collating elements in fnmatch (bug 17396, bug 16976)


On Jan 10 2019, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:

> On 10/01/2019 06:43, Andreas Schwab wrote:
>> On Jan 09 2019, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:
>> 
>>> On 09/01/2019 12:31, Andreas Schwab wrote:
>>>> diff --git a/sysdeps/i386/i686/multiarch/wmemcmp.c b/posix/tst-fnmatch4.c
>>>> similarity index 59%
>>>> copy from sysdeps/i386/i686/multiarch/wmemcmp.c
>>>> copy to posix/tst-fnmatch4.c
>>>> index ce25991352..370265ddf0 100644
>>>> --- a/sysdeps/i386/i686/multiarch/wmemcmp.c
>>>> +++ b/posix/tst-fnmatch4.c
>>>> @@ -1,6 +1,5 @@
>>>> -/* Multiple versions of wmemcmp.
>>>> -   All versions must be listed in ifunc-impl-list.c.
>>>> -   Copyright (C) 2017-2019 Free Software Foundation, Inc.
>>>
>>> I think something is wrong with git format-patch here.
>> 
>> I which way?
>
> It is kind hard to evaluate the changes when diff is against unrelated files.

59% is greater than the default 50% renameLimit.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]