This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] en_US: define date_fmt (bug 24046)
- From: Rafal Luzynski <digitalfreak at lingonborough dot com>
- To: Aurelien Jarno <aurelien at aurel32 dot net>, libc-alpha at sourceware dot org
- Date: Mon, 7 Jan 2019 12:04:31 +0100 (CET)
- Subject: Re: [PATCH v2] en_US: define date_fmt (bug 24046)
- References: <20190106171929.13106-1-aurelien@aurel32.net>
6.01.2019 18:19 Aurelien Jarno <aurelien@aurel32.net> wrote:
>
>
> The en_US locale use a 12h am/pm format in both d_fmt and d_t_fmt, which
> is correct, but does not define date_fmt. This cause the default value
> to be used, which is in 24h format.
>
> This patch adds the date_fmt entry to the en_US locale with the same
> value as d_t_fmt as the latter already includes the timezone.
>
> Changelog
> [BZ #24046]
> * localedata/locales/en_US (date_fmt): Set to
> "%a %d %b %Y %r %Z".
Now it does not say that this is a new field. I would do:
* localedata/locales/en_US (date_fmt): Add, set to
"%a %d %b %Y %r %Z".
or
* localedata/locales/en_US (date_fmt): New field, set to
"%a %d %b %Y %r %Z".
But maybe I'm expecting too much. I wonder what more experienced
maintainers think about it.
Otherwise the patch looks perfect to me and Siddhesh also said it's
OK for master so... please commit with the change as suggested above
(or without that change if you don't agree).
Thanks,
Rafal