This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/2] posix: Clear close-on-exec for posix_spawn adddup2 (BZ#23640)
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 2 Jan 2019 11:39:41 -0200
- Subject: Re: [PATCH 2/2] posix: Clear close-on-exec for posix_spawn adddup2 (BZ#23640)
- References: <20180919224624.3920-1-adhemerval.zanella@linaro.org> <20180919224624.3920-2-adhemerval.zanella@linaro.org> <87k1jn48sm.fsf@oldenburg2.str.redhat.com>
On 02/01/2019 09:07, Florian Weimer wrote:
> * adhemerval zanella:
>
>> diff --git a/posix/tst-spawn.c b/posix/tst-spawn.c
>> index 638ba1ba55..2354417020 100644
>> --- a/posix/tst-spawn.c
>> +++ b/posix/tst-spawn.c
>> @@ -40,17 +40,19 @@ static int restart;
>> static char *name1;
>> static char *name2;
>> static char *name3;
>> +static char *name5;
>>
>> /* Descriptors for the temporary files. */
>> static int temp_fd1 = -1;
>> static int temp_fd2 = -1;
>> static int temp_fd3 = -1;
>> +static int temp_fd5 = -1;
>
> What happened to name4 and temp_fd4? fe4string is not used, either.
>
> Thanks,
> Florian
I used fd5 for consistency with handle_restart local fdX and do_test
fdXname.