This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] posix: Clear close-on-exec for posix_spawn adddup2 (BZ#23640)



On 02/01/2019 09:07, Florian Weimer wrote:
> * adhemerval zanella:
> 
>> diff --git a/posix/tst-spawn.c b/posix/tst-spawn.c
>> index 638ba1ba55..2354417020 100644
>> --- a/posix/tst-spawn.c
>> +++ b/posix/tst-spawn.c
>> @@ -40,17 +40,19 @@ static int restart;
>>  static char *name1;
>>  static char *name2;
>>  static char *name3;
>> +static char *name5;
>>  
>>  /* Descriptors for the temporary files.  */
>>  static int temp_fd1 = -1;
>>  static int temp_fd2 = -1;
>>  static int temp_fd3 = -1;
>> +static int temp_fd5 = -1;
> 
> What happened to name4 and temp_fd4?  fe4string is not used, either.
> 
> Thanks,
> Florian

I used fd5 for consistency with handle_restart local fdX and do_test
fdXname.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]