This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] en_US: define date_fmt (bug 24046)


31.12.2018 00:54 Aurelien Jarno <aurelien@aurel32.net> wrote:
> 
> 
> The en_US locale use a 12h am/pm format in both d_fmt and d_t_fmt, which
> is correct, but does not define date_fmt. This cause the default value
> to be used, which is in 24h format.

I thought it was deliberate.  But indeed,
AFAIK 24h clock is not commonly understood
in the USA.  Are you a local citizen and
can you confirm?

> [...]
> Changelog
> 	[BZ #24046]
> 	* localedata/locales/en_US (date_fmt): Define.

I'm not sure that your comment is wrong but
when I add a new field I'm also trying to
quote its value.  I think it is weird that
we quote a value when we change it but not
when we define it for the first time.

> ---
>  ChangeLog                | 5 +++++
>  localedata/locales/en_US | 3 +++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/ChangeLog b/ChangeLog
> index a2170167c7..8f90d99290 100644
> --- a/ChangeLog
> +++ b/ChangeLog

Please remove changes to ChangeLog itself
when posting here.  It makes your patchwork
impossible to apply.  However, it's not a big
problem in case of such a trivial patch.


> diff --git a/localedata/locales/en_US b/localedata/locales/en_US
> index 5e2b365659..2c808bbfb6 100644
> --- a/localedata/locales/en_US
> +++ b/localedata/locales/en_US
> @@ -117,6 +117,9 @@ t_fmt   "%r"
>  % Appropriate AM/PM time representation (%r)
>  t_fmt_ampm "%I:%M:%S %p"
>  %
> +% Appropriate date representation (date(1))

I know that many locales have this comment
already but can we invent something different
to avoid nested parentheses here?

Otherwise looks OK.  This is the last day
before freeze so please wait several hours
and feel free to push to master if nobody
complains and if you are sure it is correct.

I'm out of my PC, unable to test, posting
from my phone.

Regards,

Rafal


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]