This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] x86: Use generic vector computations in s_sincosf.h

On 17/12/18 4:27 AM, H.J. Lu wrote:

Here is the updated patch to use generic vector computations only for
x86.  Tested on i686 and x86-64.  OK for master branch?
I assume you'll add the original description to this so that there's a clearer git commit log. 



Thanks.

H.J.
--
Use generic vector computations in s_sincosf.h to support vectorized
s_sincosf.  Update __sincosf_table for vectorized s_sincosf.  On
Broadwell, bench-sincosf shows:

        Before         After      Improvement
max    160.273        114.198        40%
min    6.25           5.625          11%
mean   13.0325        10.6462        22%

Vectorized sincosf_poly shows

        Before         After      Improvement
max    138.653        114.198        21%
min    5.004          5.625          -11%
mean   11.5934        10.6462        9%
I assume Wilco's performance gain also remains with this patch given that the crux of the code hasn't changed. 

Looks OK to me.

Siddhesh
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]