This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Improve bench-strlen

From: Siddhesh Poyarekar <siddhesh at gotplt dot org>
To: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>, 'GNU C Library' <libc-alpha at sourceware dot org>
Cc: nd <nd at arm dot com>
Date: Fri, 21 Dec 2018 21:24:37 +0530
Subject: Re: [PATCH] Improve bench-strlen
References: <DB5PR08MB103004B8B2973917D6791AA183B80@DB5PR08MB1030.eurprd08.prod.outlook.com> <cafcb6c6-8852-95b9-c886-f652dbf12645@gotplt.org> <DB5PR08MB1030F9F27DA590B068CC0F5783B80@DB5PR08MB1030.eurprd08.prod.outlook.com>

On 21/12/18 9:14 PM, Wilco Dijkstra wrote:

Absolutely. I already did a few more, but wanted to get one out for review to
get some feedback. I'm also planning to remove the "stupid_xxx" variants as
they don't make sense at all.


Agreed.

The other thing we need to do is increase iterations to get more accurate results
and sort out the odd buffer handling from page counts to bytes (with the default
increased so you don't have to request more in many cases). And then we can
look into improving the actual tests run, for example I already mentioned we run
too many combinations in various tests (particularly unaligned) for the results to
be meaningful.


Sounds good.

Siddhesh

References:
- [PATCH] Improve bench-strlen
  - From: Wilco Dijkstra
- Re: [PATCH] Improve bench-strlen
  - From: Siddhesh Poyarekar
- Re: [PATCH] Improve bench-strlen
  - From: Wilco Dijkstra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]