This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3] Y2038: make __difftime compatible with 64-bit time
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Albert ARIBAUD <albert dot aribaud at 3adev dot fr>
- Cc: <libc-alpha at sourceware dot org>
- Date: Wed, 19 Dec 2018 20:40:14 +0000
- Subject: Re: [PATCH v3] Y2038: make __difftime compatible with 64-bit time
- References: <20181013211641.5215-1-albert.aribaud@3adev.fr> <20181013231828.33e74b22@athena> <20181205120529.2f473669@athena> <20181219213041.34a7fb6d@athena>
On Wed, 19 Dec 2018, Albert ARIBAUD wrote:
> On Wed, 5 Dec 2018 12:05:29 +0100, Albert ARIBAUD
> <albert.aribaud@3adev.fr> wrote :
>
> > On Sat, 13 Oct 2018 23:18:28 +0200, Albert ARIBAUD
> > <albert.aribaud@3adev.fr> wrote :
> >
> > > On Sat, 13 Oct 2018 23:16:41 +0200, "Albert ARIBAUD (3ADEV)"
> > > <albert.aribaud@3adev.fr> wrote :
> > >
> > > > Provide a 64-bit-time version of __difftime (but do not assume
> > > > __time64_t is a signed int so that Gnulib can reuse the code)
> > > > and make the 32-bit version a wrapper of it.
> > >
> > > Note: this patch applies over the __time64_t patch series v10. The
> > > whole series can be found as branch aaribaud/y2038 on the glibc repo.
> >
> > Any comments on this patch?
>
> Ping -- just rebased and re-ran make checks on this patch, still good.
<https://sourceware.org/ml/libc-alpha/2018-10/msg00225.html> is missing
libc_hidden_proto / libc_hidden_def for __difftime64, and is missing ". "
at the end of a comment. (If that's not the version for which you want
review, you should give the URL to a patch when pinging it....)
--
Joseph S. Myers
joseph@codesourcery.com