This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] testsuite fix: timezone: failing due to permissions in cross testing

From: Paul Eggert <eggert at cs dot ucla dot edu>
To: Vineet Gupta <vineet dot gupta1 at synopsys dot com>, libc-alpha at sourceware dot org
Cc: linux-snps-arc at lists dot infradead dot org
Date: Mon, 17 Dec 2018 15:17:27 -0800
Subject: Re: [PATCH] testsuite fix: timezone: failing due to permissions in cross testing
References: <1545088170-24103-1-git-send-email-vgupta@synopsys.com>

  #ifdef S_IRUSR
-#define MKDIR_UMASK (S_IRUSR|S_IWUSR|S_IXUSR|S_IRGRP|S_IXGRP|S_IROTH|S_IXOTH)
+#define MKDIR_UMASK (S_IRUSR|S_IWUSR|S_IXUSR|S_IRGRP|S_IWGRP|S_IXGRP|S_IROTH|S_IWOTH|S_IXOTH)
  #else
  #define MKDIR_UMASK 0755
  #endif

The zic.c code is taken from upstream, and I'm loath to change iteverywhere simply because a glibc test driver isn't working somewhere,as I expect this would lead to security holes elsewhere. Intead, howabout changing the test script to chmod the testdata directory after ziccreates it, or to segregate the tzdata directory from the other testresults?

Follow-Ups:
- Re: [PATCH] testsuite fix: timezone: failing due to permissions in cross testing
  - From: Vineet Gupta

References:
- [PATCH] testsuite fix: timezone: failing due to permissions in cross testing
  - From: Vineet Gupta

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]