Re: [PATCH 1/5] Y2038: add function __localtime64_r

[Joseph Myers <joseph at codesourcery dot com>]

On Mon, 17 Dec 2018, Albert ARIBAUD (3ADEV) wrote:

> +/* Provide a 32-bit variant if needed */

Throughout this series, please make sure comments end with ".  " (full 
stop, two spaces) before end of comment.  You have the same mistake in 
other patches in this series.

You're declaring __localtime64_r with attribute_hidden.  Although not 
strictly wrong at this stage, since the point is eventually to export it 
from libc it would be better to declare it without attribute_hidden, and 
instead use libc_hidden_proto / libc_hidden_def (those are needed because 
of the call from __localtime_r).  Otherwise you'll need to remove the 
attribute_hidden, and add the libc_hidden_*, in a later patch that exports 
or prepares to export the functions.

-- 
Joseph S. Myers
joseph@codesourcery.com