This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] x86: Add Hygon Dhyana support.

On 12/12/2018 10:32 PM, Carlos O'Donell wrote:

On 12/12/18 2:21 AM, Jinke Fan wrote:

Thank you for your reply and reminder.

The copyright issue is already under processing.
Jinke, 

Please review the attached patch. It is what I plan to commit for you.

I notice you use 'fanjinke' as your ChangeLog name, is that correct?

I added a 'Signed-off-by' for you in the commit message, is that OK?

The only changes I made to your patch:

* Finished the ChangeLog entry which was missing text after the
   identified function change.

* Added space after '.' in comment in cpu-features.c (two spaces after
   period is GNU coding convention).

If everything looks OK to you I will commit this for you.


Carlos,

Yes, everything looks OK to me.

Thank you very much!
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]