This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] powerpc: Add missing CFI register information [BZ #23614]
- From: Tulio Magno Quites Machado Filho <tuliom at linux dot ibm dot com>
- To: "Gabriel F. T. Gomes" <gabriel at inconstante dot eti dot br>
- Cc: libc-alpha at sourceware dot org
- Cc:
- Date: Wed, 12 Dec 2018 11:10:35 -0200
- Subject: Re: [PATCH] powerpc: Add missing CFI register information [BZ #23614]
- References: <20180906214302.3158-1-tuliom@linux.ibm.com> <20180928160043.656bdb95@tereshkova>
"Gabriel F. T. Gomes" <gabriel@inconstante.eti.br> writes:
> On Thu, 06 Sep 2018, Tulio Magno Quites Machado Filho wrote:
>
>>diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc64/brk.S b/sysdeps/unix/sysv/linux/powerpc/powerpc64/brk.S
>>index c8cb7edf77..fa769add4d 100644
>>--- a/sysdeps/unix/sysv/linux/powerpc/powerpc64/brk.S
>>+++ b/sysdeps/unix/sysv/linux/powerpc/powerpc64/brk.S
>>@@ -29,6 +29,7 @@ ENTRY (__brk)
>> CALL_MCOUNT 1
>>
>> std r3,-8(r1)
>>+ cfi_offset(r3, -8)
>> DO_CALL(SYS_ify(brk))
>> ld r6,-8(r1)
>> ld r5,.LC__curbrk@toc(r2)
>
>
> As mentioned in https://sourceware.org/bugzilla/show_bug.cgi?id=23614#c1,
> this is not needed.
>
> Looks good to me with this hunk removed and ChangeLog updated.
>
> Reviewed-by: Gabriel F. T. Gomes <gabriel@inconstante.eti.br>
Removed and pushed as 1d880d4a9bf7608c2cd33bbe954ce6995f79121a.
Thanks!
--
Tulio Magno