This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/2] linux: Consolidate sigaction implementation
- From: Andreas Schwab <schwab at suse dot de>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 10 Dec 2018 17:28:14 +0100
- Subject: Re: [PATCH 1/2] linux: Consolidate sigaction implementation
- References: <1510950884-1969-1-git-send-email-adhemerval.zanella@linaro.org>
On Nov 17 2017, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:
> - All architectures now define and use a kernel_sigaction struct meant
> for the syscall, even for the architectures where the user sigaction
> has the same layout of the kernel expected one (s390-64 and ia64).
> Although it requires more work for these architectures, it simplifies
> the generic implementation. Also, sigaction is hardly a hotspot where
> micro optimization would play an important role.
>
> - The generic kernel_sigaction definition is now aligned with expected
> UAPI one for newer ports, where SA_RESTORER and sa_restorer is not
> expected to be defined. This means adding kernel_sigaction for
> current architectures that does define it (m68k, nios2, powerpc, s390,
> sh, sparc, and tile) and which rely on previous generic definition.
There is no need to define kernel_sigaction in more than one file, since
it is the same (except for the presense of sa_restorer) for all
architectures.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."