Re: [PATCH 2/2] Multiple locales: Use the correct 12-hour time formats

[TAMUKI Shoichi <tamuki at linet dot gr dot jp>]

Hello Rafal,

From: Rafal Luzynski <digitalfreak@lingonborough.com>
Subject: [PATCH 2/2] Multiple locales: Use the correct 12-hour time formats (bug 10496).
Date: Wed, 7 Nov 2018 23:53:31 +0100 (CET)

> It has been disovered that some locales use the 12-hour time formats but
> do not use any AM/PM indicator thus making the time ambiguous.  This
> commit adds "%p" wherever it was missing.  In some cases it has been
> identified that a locale should use 24-hour time format rather than
> 12-hour.  All time formats come from CLDR but this commit introduces as
> few changes as possible (for example, it tries not to change the time zone
> display).  For the locales which are not supported by CLDR the consistency
> with similar locales (which means the same language or the same country)
> has been preserved: if the time formats were the same before the change
> then they are still the same after the change.

I think that the change to use the correct 12-hour time formats needs
to be carefully considered.  In some locales, although 12-hour formats
are commonly used, there seem to be cases where there is no custom of
using the AM/PM indicator.

In this case, although it certainly becomes ambiguous, it seems that
there is a case where it can be judged in the context or supplemented
by adding "in the morning" to avoid ambiguity for example.

So, I think that it needs to take it into account to change 12-hour
time format to 24-hour time format.

Regards,
TAMUKI Shoichi