This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add getcpu


On Fri, Dec 7, 2018 at 4:51 AM Tulio Magno Quites Machado Filho
<tuliom@ascii.art.br> wrote:
>
> "H.J. Lu" <hjl.tools@gmail.com> writes:
>
> >       * NEWS: Mention getcpu.
> >       * include/sched.h (__getcpu): New libc_hidden_proto.
> >       * sysdeps/unix/sysv/linux/Makefile (sysdep_routines): Add getcpu.
> >       * sysdeps/unix/sysv/linux/Versions (GLIBC_2.29): Add getcpu.
> >       * sysdeps/unix/sysv/linux/aarch64/libc.abilist: Add getcpu.
> >       * sysdeps/unix/sysv/linux/alpha/libc.abilist: Likewise.
> >       * sysdeps/unix/sysv/linux/arm/libc.abilist: Likewise.
> >       * sysdeps/unix/sysv/linux/hppa/libc.abilist: Likewise.
> >       * sysdeps/unix/sysv/linux/i386/libc.abilist: Likewise.
> >       * sysdeps/unix/sysv/linux/ia64/libc.abilist: Likewise.
> >       * sysdeps/unix/sysv/linux/m68k/coldfire/libc.abilist: Likewise.
> >       * sysdeps/unix/sysv/linux/m68k/m680x0/libc.abilist: Likewise.
> >       * sysdeps/unix/sysv/linux/microblaze/libc.abilist: Likewise.
> >       * sysdeps/unix/sysv/linux/mips/mips32/fpu/libc.abilist: Likewise.
> >       * sysdeps/unix/sysv/linux/mips/mips32/nofpu/libc.abilist:
> >       Likewise.
> >       * sysdeps/unix/sysv/linux/mips/mips64/n32/libc.abilist: Likewise.
> >       * sysdeps/unix/sysv/linux/mips/mips64/n64/libc.abilist: Likewise.
> >       * sysdeps/unix/sysv/linux/nios2/libc.abilist: Likewise.
> >       * sysdeps/unix/sysv/linux/powerpc/powerpc32/fpu/libc.abilist:
> >       Likewise.
> >       * sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/libc.abilist:
> >       Likewise.
> >       * sysdeps/unix/sysv/linux/powerpc/powerpc64/libc.abilist:
> >       Likewise.
>
> I noticed the powerpc64le abilist file is missing in the ChangeLog.

Fixed.

> >  NEWS                                          |  3 ++
> >  include/sched.h                               |  2 +
> >  sysdeps/unix/sysv/linux/Makefile              |  2 +-
> >  sysdeps/unix/sysv/linux/Versions              |  3 ++
> >  sysdeps/unix/sysv/linux/aarch64/libc.abilist  |  1 +
> >  sysdeps/unix/sysv/linux/alpha/libc.abilist    |  1 +
> >  sysdeps/unix/sysv/linux/arm/libc.abilist      |  1 +
> >  sysdeps/unix/sysv/linux/bits/sched.h          |  3 ++
> >  sysdeps/unix/sysv/linux/getcpu.c              | 38 +++++++++++++++++++
> >  sysdeps/unix/sysv/linux/hppa/libc.abilist     |  1 +
> >  sysdeps/unix/sysv/linux/i386/libc.abilist     |  1 +
> >  sysdeps/unix/sysv/linux/ia64/libc.abilist     |  1 +
> >  .../sysv/linux/m68k/coldfire/libc.abilist     |  1 +
> >  .../unix/sysv/linux/m68k/m680x0/libc.abilist  |  1 +
> >  .../unix/sysv/linux/microblaze/libc.abilist   |  1 +
> >  .../sysv/linux/mips/mips32/fpu/libc.abilist   |  1 +
> >  .../sysv/linux/mips/mips32/nofpu/libc.abilist |  1 +
> >  .../sysv/linux/mips/mips64/n32/libc.abilist   |  1 +
> >  .../sysv/linux/mips/mips64/n64/libc.abilist   |  1 +
> >  sysdeps/unix/sysv/linux/nios2/libc.abilist    |  1 +
> >  .../linux/powerpc/powerpc32/fpu/libc.abilist  |  1 +
> >  .../powerpc/powerpc32/nofpu/libc.abilist      |  1 +
> >  .../linux/powerpc/powerpc64/libc-le.abilist   |  1 +
>
> While you're making the correct changes.  So, just a ChangeLog entry missing.
>
> This patch will conflict with an earlier patch from Andreas Schwab:
> https://sourceware.org/ml/libc-alpha/2018-11/msg00752.html

One of us has to resolve the conflict.

-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]