This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix test-as-const-jmp_buf-ssp.c generation on gnu-i386
- From: Samuel Thibault <samuel dot thibault at gnu dot org>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: "Joseph S. Myers" <joseph at codesourcery dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 3 Dec 2018 17:29:45 +0100
- Subject: Re: [PATCH] Fix test-as-const-jmp_buf-ssp.c generation on gnu-i386
- References: <20181201231247.p7z3veulcqxfd2o2@function> <alpine.DEB.2.21.1812031323360.28539@digraph.polyomino.org.uk> <20181203134222.u6bwhpyj5xsoipii@function> <CAMe9rOqL7vq1O7-FFOp9YtcYf-o=JS7iFn5-9w1uEhsQ5eac=g@mail.gmail.com>
H.J. Lu, le lun. 03 déc. 2018 08:17:23 -0800, a ecrit:
> On Mon, Dec 3, 2018 at 5:42 AM Samuel Thibault <samuel.thibault@gnu.org> wrote:
> >
> > Joseph Myers, le lun. 03 déc. 2018 13:23:48 +0000, a ecrit:
> > > On Sat, 1 Dec 2018, Samuel Thibault wrote:
> > >
> > > > 2018-12-01 Samuel Thibault <samuel.thibault@ens-lyon.org>
> > > >
> > > > * scripts/gen-as-const.py (main): Avoid emitting empty line when
> > > > there is no element in `consts'.
> > >
> > > OK, please commit.
> >
> > Done so, thanks.
>
> I still got
>
> /export/ssd/build/tools-build/glibc-many/src/glibc/csu/../sysdeps/i386/start.S:122:
> undefined reference to `main'
Yes, see my second mail in the same thread:
“
That said, it's not enough, gen_test() does not emit a main() function,
and thus the test build fails with missing reference to main(). Is there
a strong reason for making the emission of code lazy with the started
boolean?
”
which needs to be discussed too.
Samuel