This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/3] Update s_sincosf.c and x86-64 s_sincosf-fma.c
- From: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, Szabolcs Nagy <Szabolcs dot Nagy at arm dot com>, "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: 'GNU C Library' <libc-alpha at sourceware dot org>, nd <nd at arm dot com>
- Date: Mon, 3 Dec 2018 12:13:15 +0000
- Subject: Re: [PATCH 1/3] Update s_sincosf.c and x86-64 s_sincosf-fma.c
Hi Adhemerval,
> I did check on a A53 I saw no regressions with benchtests. Do you see any
> regressions on other chips or systems?
Cortex-A53 doesn't support 128-bit loads, however most other AArch64 cores do.
> If it is the case one option could be use my suggestion to move s_sincosf_t
> to its own header.
Well there is no need to change the existing structure, it's small so the vector
version could just add a new structure. In fact I can't see why any of this should
be target specific. GCC supports generic vector notation, so that should be the
obvious approach for this optimization.
Wilco