This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] support: Close original descriptors in support_capture_subprocess

On Dez 01 2018, Florian Weimer <fweimer@redhat.com> wrote:

> This means that stdout_pipe[1] is at least 1 and stderr_pipe[1] is at
> least 3.  We can never close descriptor 0, but the first xclose could
> close descriptor 1 or 2.  Should I remove the second if condition?

IMHO it would be cleaner that if a test needs a closed standard fd there
should be a separate functionality to set that up instead of letting the
test close it directly.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]