This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v10] Mutex: Add pthread mutex tunables
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Kemi Wang <kemi dot wang at intel dot com>, Glibc alpha <libc-alpha at sourceware dot org>
- Date: Fri, 30 Nov 2018 17:04:34 -0500
- Subject: Re: [PATCH v10] Mutex: Add pthread mutex tunables
- References: <1543565573-1419-1-git-send-email-kemi.wang@intel.com>
On 11/30/18 3:12 AM, Kemi Wang wrote:
> ChangeLog:
> V9->V10:
> a) Remove superfluous comments, as suggested by Adhemerval Zanella
> b) Use max_adaptive_count() to get the maximum spin count, as suggested
> by Adhemerval Zanella
> c) Move DEFAULT_ADAPTIVE_COUNT definition to a generic header and
> override this header by the architecture in future, as suggested by
> Adhemerval Zanella
> d) Use macro DEFAULT_ADAPTIVE_COUNT to replace magic number 100, as
> suggested by Carlos
> e) Other minor change on tunable description, as suggested by Carlos
> f) Change maximum value of adaptive spin count from 30000 to 32767(full
> short range), as suggested by Adhemerval Zanella.
> g) Move "struct mutex_config" definition back to pthread_mutex_conf.h,
> thus, the header pthreadP.h does not have to be included in
> pthread_mutex_conf.c
I just wanted to publicly thank you for going 10 iterations to get this
patch into the state that it is in today. I appreciate your patience,
professionalism, and attention to detail. I hope to review more of your
patches in the future :-)
--
Cheers,
Carlos.