This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] support: Implement <support/descriptors.h> to track file descriptors
* Rafal Luzynski:
> 27.11.2018 18:25 Florian Weimer <fweimer@redhat.com> wrote:
>>
>>
>> 2018-11-27 Florian Weimer <fweimer@redhat.com>
>>
>> * support/descriptors.h: New file.
>> * support/check.h (support_record_failure_is_failed): Declare.
>
> OK
>
>> * support/support_descriptors.c: Likewise.
>> * support/tst-support_descriptors.c: Likewise.
>
> These "Likewise" look like "Declare" but I'm pretty sure you meant
> "New file". Please use "New file" instead of the first "Likewise"
> or maybe better just reorder the lines so that "Likewise" follows
> "New file". I think it is reasonable to put "check.h" in the first
> line, this sorts the entries alphabetically and resolves the problem.
>
>> * support/support_record_faile.c
>
> ^faile^failure
Thanks, will fix.
>> (support_record_failure_is_failed): New function.
>> [...]
>> +static int
>> +do_test (void)
>> +{
>> + puts ("info: initial descriptor set");
>> + {
>> + struct support_descriptors *descrs = support_descriptors_list ();
>> + support_descriptors_dump (descrs, "info: ", stdout);
>
> Are you sure you need two spaces here? --------^^
>
> The same again few lines below.
Yes, it's for expected/actual alignment in the output.
Thanks,
Florian